Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANNOUNCEMENT: EmailJS 2017+ #158

Closed
felixhammerl opened this issue Nov 5, 2017 · 3 comments
Closed

ANNOUNCEMENT: EmailJS 2017+ #158

felixhammerl opened this issue Nov 5, 2017 · 3 comments

Comments

@felixhammerl
Copy link
Contributor

felixhammerl commented Nov 5, 2017

Hi y'all,

how do you use the email js libs? I've been on a longer hiatus, but I'm planning on dropping in again more in the future. For that reason, I'd like to re-assess the scope of this project, since some of the basic assumptions changed:

  • Chrome Apps is dead, so the dreaded Chrome socket shim can be removed
  • Transpilers are up to the task and most really shitty old platforms are gone for good
  • An ES2017 refactor will dramatically reduce code
  • UMD is gone in favor of webpack and the likes.
  • Let's throw out the task runners in favor of shell scripts
  • Standardjs linting

What do y'all think about this?
On which platforms are you using emailjs?

EDIT:
This happens in a major version bump, so y'all can continue pretty much undisturbed.

@felixhammerl felixhammerl changed the title SURVEY: How do you use the emailJS libraries? ANNOUNCEMENT: EmailJS 2017+ Nov 5, 2017
@nifgraup
Copy link
Contributor

nifgraup commented Nov 7, 2017

Sounds good. Getting 2 spaces in return for losing the semi colon seems like a fair trade, but I'm not going to bikeshed JS lint style :). We use emailjs at Vivaldi with the chrome.socket API. It is still working in the Chromium project but eventually it will go away. That means either adopting chrome.socket or switching to something else.

@felixhammerl
Copy link
Contributor Author

4 or 2 spaces, I don't care either. But it's a package deal and standardjs is a pretty good linter with a decent code style that works out of the box, so i'll take the 2 spaces :)

I'll see to it that compatibility need not be unnecessarily broken. It the socket shim causes problems, I'll think about removing it. Downside is the cost of having to rewrite the socket code. Let's cross that bridge when we get there :)

@felixhammerl
Copy link
Contributor Author

@nifgraup found a way to make the tcp socket work after all :)
https://github.com/emailjs/emailjs-tcp-socket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants