OCaml parser and first functions added #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
reviewed
Jul 29, 2022
There was a problem hiding this comment.
There are couple of warnings, let's try to avoid it as possible.
In toplevel form:
ts-fold.el:457:1:Warning: variable ‘_’ not left unused
ts-fold.el:457:1:Warning: Unused lexical argument ‘offset’
ts-fold.el:473:1:Warning: variable ‘_’ not left unused
ts-fold.el:473:1:Warning: Unused lexical argument ‘offset’
ts-fold.el:489:1:Warning: variable ‘_’ not left unused
ts-fold.el:489:1:Warning: Unused lexical argument ‘offset’
ts-fold.el:515:1:Warning: variable ‘_’ not left unused
ts-fold.el:515:1:Warning: Unused lexical argument ‘offset’
mattiasdrp
force-pushed
the
ocaml-parser
branch
4 times, most recently
from
3bb9f9c to
fcdc407
Compare
|
I got rid of the warnings by enclosing the when-let in an unless |
jcs090218
reviewed
Jul 29, 2022
|
Can you update our README file as well? Add OCaml to supported languages list! Thanks! |
|
I think you name the function to |
jcs090218
reviewed
Jul 29, 2022
jcs090218
reviewed
Jul 29, 2022
There was a problem hiding this comment.
Some warnings we should address:
ts-fold.el:474:1:Warning: Unused lexical argument ‘offset’
ts-fold.el:488:1:Warning: Unused lexical argument ‘offset’
ts-fold.el:502:1:Warning: Unused lexical argument ‘offset’
ts-fold.el:522:1:Warning: Unused lexical argument ‘offset’
Others LGTM! Thanks for the hard work! ❤️ Let me know if this is ready to merge! Thanks!
This update allows to fold comments, value, type and module definitions if they're not on one line only I'm not sure about the one line rule but it seems strange to fold a value that fits on one line
|
Should be good now! Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows to fold comments, value, type and module definitions if they're not on one line only
I'm not sure about the one line rule but it seems strange to fold a value that fits on one line
resolves #18