Skip to content

Add support for the CodeQL Query Language #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

anticomputer
Copy link

This PR adds support for: https://github.com/tree-sitter/tree-sitter-ql

Note: passes tests and compiles cleanly. I've tested the resulting tree-sitter binary artifacts locally and they work as expected.

@@ -133,7 +133,8 @@ See `tree-sitter-langs-repos'."
(swift-mode . swift)
(tuareg-mode . ocaml)
(typescript-mode . typescript)
(zig-mode . zig))))
(zig-mode . zig)
(ql-mode . ql))))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there already a ql-mode for Emacs? I couldn't find one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no there's not. I'm working on one which uses tree-sitter based highlighting, hence this PR, but it's not released yet.

If you prefer, we can just park this PR until the mode is publicly available and I'll revive it then, or we can remove this default association and just keep the upstream repo addition?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the default association to ql-mode for now in favor of being able to include the ql tree-sitter artifacts in tree-sitter-langs

@ubolonton
Copy link
Collaborator

Thanks!

This package currently provides queries only for tree-sitter-hl. Please remove non-hl queries.

@anticomputer
Copy link
Author

Thanks!

This package currently provides queries only for tree-sitter-hl. Please remove non-hl queries.

Done :)

ql-mode is not widely available, removing the default association in favor of just including the ql tree-sitter artifacts as part of the package distribution.
@anticomputer
Copy link
Author

I've released a ql mode included with https://github.com/anticomputer/emacs-codeql, it is named ql-tree-sitter-mode, however I don't expect that to become a default association as it is not on MELPA yet. It would be great if we could include the tree-sitter-ql binary artifact as part of the tree-sitter-langs release though. If not possible, I'll continue packaging my own builds with the emacs-codeql package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants