Add tlaplus #44
Open
Add tlaplus #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: tree-sitter/tree-sitter#1336 |
ahelwer
reviewed
Oct 3, 2021
| [submodule "repos/tlaplus"] | ||
| path = repos/tlaplus | ||
| url = https://github.com/tlaplus-community/tree-sitter-tlaplus.git | ||
| branch = master |
There was a problem hiding this comment.
I think the default branch on the repo is main, not master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to utilize this fork in my bare-bones tla-mode for syntax highlighting of TLA+. I hope you can accept my contribution!
Now, as for the strange
config.json, while I was trying to get this all working I kept crashing into an error:(more at my readme
Eventually I figured out that in tree-sitter-tlaplus @ahelwer is using a fork of version
0.20oftree-sitter-cli. But the important bit is not the fork, but that in that version the CLI looks for aconfig.jsonwhenTREE_SITTER_DIRis set in the environment. Because this package sets that env to the source directory during compile, it tries to find this config and fails, then crashes.Uh, possibly the more correct thing to do is make another PR over there so they don't crash if there's no config file rather than to put an empty config file here, but at any rate it does compile correctly and fine with
0.20. If I put the empty config file.At least, that's what I think is happening. I don't really know Rust so I can't be certain of whom is at fault, or how to fix it. I already stretched my knowledge of elisp this time, which was fun!