- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8
update font rules, indention, faces and readme #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +363
        
        
          −21
        
        
          
        
      
    
  
  
     Merged
                    Changes from 11 commits
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      d2b528c
              
                update font rules, indention, faces and readme
              
              
                craynot 2da0cf3
              
                add test
              
              
                craynot 1792150
              
                default statement indent + font rules
              
              
                craynot 8d02f81
              
                built-in functions highlight
              
              
                craynot bf1dade
              
                object_creation_expression qualified_name highlight
              
              
                craynot 8128af1
              
                face tests
              
              
                craynot 115c8a0
              
                add tests
              
              
                craynot 8306fd7
              
                update rules and tests
              
              
                craynot 975f556
              
                add match expression indent, update keywords
              
              
                craynot 27ae09e
              
                instanceof keyword and class highlight
              
              
                craynot 8c09f38
              
                remove php-ts-face
              
              
                craynot b7eb352
              
                remove built-in feature
              
              
                craynot e59eeb3
              
                update use_declaration and class_interface_clause rules
              
              
                craynot File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| *.elc | ||
| php-ts-mode-autoloads.el | ||
| php-ts-mode-pkg.el | ||
| /.eask | ||
| /dist | ||
| # emacs tmp files | ||
| *~ | ||
| *# | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add a test for this case?
We have very basic suite here: https://github.com/emacs-php/php-ts-mode/blob/master/tests/php-ts-mode-resources/indent.erts
It would be great to increase the coverage while we fix issues.