Skip to content

Conversation

@jcs090218
Copy link
Member

CI improvements! :)

@jcs090218 jcs090218 requested a review from zonuexe September 13, 2023 01:20
@zonuexe
Copy link
Member

zonuexe commented Sep 13, 2023

@jcs090218 Thank you, I want to see Eask in action right away, so I merge this 😄

@zonuexe zonuexe merged commit 71ace73 into emacs-php:master Sep 13, 2023
@zonuexe
Copy link
Member

zonuexe commented Sep 13, 2023

https://github.com/emacs-php/php-mode/actions/runs/6166874224

windows-latest tends to fail, so maybe we should tolerate failure.
Also, macos-* is also a little slow, so it might be a good idea to build only 28.2, 29.1, and snapshot.
I have older Emacs provided by my linux package manager so I'm testing them, but I believe macOS users are using newer Emacs.

@jcs090218
Copy link
Member Author

windows-latest tends to fail, so maybe we should tolerate failure.

Isn't the experimental flag enough? 🤔 The mark will still be red ❌, but the badge will be green CI.

Also, macos-* is also a little slow, so it might be a good idea to build only 28.2, 29.1, and snapshot.

I really like the way it acts now. It feels so consistent. 😁

I have older Emacs provided by my linux package manager so I'm testing them, but I believe macOS users are using newer Emacs.

Doesn't "manual testing" defeat the purpose of using CI/CD? 🤔 I mean I'll just let the machine run on its own! ;)

@zonuexe
Copy link
Member

zonuexe commented Sep 13, 2023

Isn't the experimental flag enough? 🤔 The mark will still be red ❌, but the badge will be green CI.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants