Mode line improvements #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In standard mode lines, the custom references title was not shown, only default " Treeemacs ". * lsp-treemacs.el (lsp-treemacs--set-mode-line-format): New function. Sets a Treemacs buffer mode-name or mode-line-format. (lsp-treemacs--show-references): Call `lsp-treemacs--set-mode-line-format`. (lsp-treemacs--do-search): Call `lsp-treemacs--set-mode-line-format`. (lsp-treemacs-references): Add a space to make the title more legible in the default mode line format. (lsp-treemacs-implementations): Add a space to make the title more legible in the default mode line format.
A couple of major modes were derived from `treemacs-mode` just to have a custom mode line, which seems unnecessary. * lsp-treemacs.el (lsp-treemacs-errors-mode): Remove major mode. (lsp-treemacs-java-deps-mode): Remove major mode. (lsp-treemacs-errors-list): Call `lsp-treemacs--set-mode-line-format`. (lsp-treemacs-java-deps-list): Call `lsp-treemacs--set-mode-line-format`.
Contributor
Author
|
@yyoncho What we discussed in Gitter. I've tested with a standard mode line and a Doom mode line and this approach seems to work as expected. It wouldn't be a bad idea to test this with Spacemacs mode line as well. |
Member
|
Looks good! We should do the same for dap-mode as well. I tested with spaceline and it works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some standard mode lines, lsp-treemacs always shows "Treemacs" in the mode line, making panes difficult to distinguish.
This PR solves the problem by setting either of these two buffer local variables:
mode-name. For Doom/Spacemacs/Moody, Treemacs builds a custommode-line-formatthat displays the mode name along with other info in a propertized way.mode-line-format. In standard mode lines, Treemacs modifies themode-line-formatto show " Treemacs ", so from lsp-treemacs we'll do the same but show a descriptive pane title instead.I think this PR supersedes #10, so I've removed the major modes that that PR created.