Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If table is a function, only passthrough if its result is non-nil #4684

Merged
merged 2 commits into from
Jan 16, 2025
Merged

If table is a function, only passthrough if its result is non-nil #4684

merged 2 commits into from
Jan 16, 2025

Conversation

wyuenho
Copy link
Contributor

@wyuenho wyuenho commented Jan 14, 2025

Follow up for #4682

kiennq
kiennq reviewed Jan 14, 2025
View reviewed changes
lsp-completion.el Outdated Show resolved Hide resolved
@wyuenho wyuenho requested a review from kiennq January 15, 2025 03:53
@kiennq kiennq merged commit 2e5f23a into emacs-lsp:master Jan 16, 2025
10 of 13 checks passed
@wyuenho wyuenho deleted the really-fix-try-completion branch January 16, 2025 06:38
@eval-exec
Copy link
Contributor

Hello @wyuenho , thank you for the fix.

I'm new to lsp-mode and would like to know where lsp:label-details-description? is defined. Could you please guide me?

@kiennq
Copy link
Member

kiennq commented Jan 24, 2025

Hello @wyuenho , thank you for the fix.

I'm new to lsp-mode and would like to know where lsp:label-details-description? is defined. Could you please guide me?

It's defined in lsp-protocol, an expansion of the macros over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiennq kiennq kiennq approved these changes

Assignees
No one assigned
Labels
completion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyuenho @eval-exec @kiennq