Add custom lsp-clients-extract-signature-on-hover
#187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a case where a type signature would be broken up over multiple lines, and we only display the first of these. Fixes: emacs-lsp#151 Related: emacs-lsp/lsp-mode#4362 Related: emacs-lsp/lsp-mode#1740
slotThe
commented
Aug 17, 2024
| "Display the type signature of the function under point." | ||
| (let* ((groups (--filter (s-equals? "```haskell" (car it)) | ||
| (-partition-by #'s-blank? | ||
| (->> (lsp-get contents :value) |
There was a problem hiding this comment.
I hope I did this right, but this should be agnostic wrt the chosen lsp-mode configuration. Still, I've only tested it with use-plists, so it would be nice if someone using hashtables could also test this
|
I wonder if a PR to upstream might get more traction? |
|
This is essentially what emacs-lsp/lsp-mode#1740 was, but that sadly also went nowhere :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like emacs-lsp/lsp-mode#4362 didn't get any traction, so I'm following what was discussed in #151 and am creating an individual PR here instead.
Before:
After:
Commit Summary
Add custom lsp-clients-extract-signature-on-hover
This fixes a case where a type signature would be broken up over multiple lines, and we only display the first of these.
Fixes: #151
Related: emacs-lsp/lsp-mode#4362
Related: emacs-lsp/lsp-mode#1740