Handle dart language-server #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dart-sdk that comes with flutter doesn't include the snapshots by default. This is also the recommended approach according to the docs.
ericdallo
reviewed
Sep 11, 2022
Lets us track which capabilities the current dart version supports, which will help for version regressions that may be introduced or for deciding what features we can use.
|
Just noticed the test failures, will resolve these when I have time 😄 |
Currently returns a formatted string
|
Apologies this took so long 😅 Added a couple more tests too, I've been using buttercup myself recently and I'm liking it more than ert. Worth looking into! Makes tests super succinct and readable |
|
Just to mention, the loaddef bug is resolved now in windows' |
Good to know! |
ericdallo
reviewed
Sep 17, 2022
Use lsp-dart-version-at-least-p instead.
elken
force-pushed
the
feat/dart-language-server
branch
from
0949acb to
c0de0bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dart-sdk that comes with flutter doesn't include the snapshots by
default.
This is also the recommended approach according to the docs.