Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-descbinds-action:describe: Wrong type argument: symbolp, "ignore-event" #27

Closed
achinhorn opened this issue Apr 28, 2019 · 4 comments

Comments

@achinhorn
Copy link

achinhorn commented Apr 28, 2019

Expected behavior

Useful help documentation should appear for commands at point when I use C-j or have C-c f enabled in a helm-descbinds window.

Actual behavior, from emacs-helm.sh if possible

C-j or C-c f and scroll around, helm documentation is not shown and I get the error helm-descbinds-action:describe: Wrong type argument: symbolp, "ignore-event"

Your issue template advises use of emacs-helm.sh. How do I use that with helm-descbinds? I tried and it doesn't load helm-descbinds...

Steps to reproduce

  1. Start emacs with helm + helm-descbinds installed via melpa.
  2. C-h b or C-h w, frame on default splash screen.
  3. Scroll down to <iconify-frame> or <make-frame-visible> which reference ignore-event, a command you might not understand and want to know more about.
  4. Press C-j (or scroll onto with C-c f helm-follow-mode enabled) to learn something about it, but instead get this error.

Not sure if important:
5. C-h b ignore-event returns 2 hits.
6. C-x c a ignore-events returns while-no-input-ignore-events var. It's value is (focus-in focus-out help-echo iconify-frame make-frame-visible selection-request). Not sure if this matters, but it looks ~~related. There is not explicit reference to ignore-events that I can find.

It appears iconify-frame and make-frame-visible are potentially menu (?) items referencing a non-existent function which aren't actually bound to any keys. (I have default gui menu, aka the top "toolbar", disabled)...
So ultimately, all this work maybe just for what was an error message I didn't understand on a function I can't find...? Not sure what's going on here.

Backtraces (M-x toggle-debug-on-error)

WARNING: long lines. ~100k char line which seem to post my entire alist of keybinds. It is navigable for me but sluggish.
helm-descbinds-debug.txt

Describe versions of Helm, Emacs, operating system, etc.

  • Helm: helm-20190424.1443
  • Emacs: 26.1 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.22.30) of 2018-06-26
  • OS: Fedora 28

Side-note: Never posted on github before and want to say thanks for a super useful adoption/discovery package! I nearly stopped using the awesome helm-apropos since installing helm-descbinds. Most of what I need is help learning Major-mode specifics including bindings and usage docs--helm-descbinds is the one!

thierryvolpiatto pushed a commit that referenced this issue Apr 29, 2019
* helm-descbinds.el (helm-descbinds-action:describe): Do it.
thierryvolpiatto pushed a commit that referenced this issue Apr 29, 2019
when candidate is a cons cell of two strings.

* helm-descbinds.el (helm-descbinds-action-transformer): Do it.
thierryvolpiatto pushed a commit that referenced this issue Apr 29, 2019
ignore or ignore-event and is a string.

* helm-descbinds.el (helm-descbinds-action:describe): Do something
more useful than nothing.
@thierryvolpiatto
Copy link
Member

thierryvolpiatto commented Apr 29, 2019 via email

@achinhorn
Copy link
Author

achinhorn commented Jun 3, 2019

Hi, thanks so much for your response. Not accustomed to git'ting, apologies on delay.

Hits for iconify-frame return docstrings now, which is better but still somewhat confusing since I expect a matching name & function. I'll need to look into your provided info page. Thanks.

I thought I ran into a bug on your fix but looks like a separate issue, can you verify:

When I hit C-h b ignore and scroll to vc-ignore, nothing pops up on C-j. After some looking, I realized the library wasn't loaded, which fixed it after I loaded it. (I don't remember this ever being an issue)

PS Calling emacs-helm.sh, M-L on helm-find-files returns no such action 'helm-find-files-load-files' for this source. Same error when calling from regular config. Just kidding, I have to find the specific .el file before hitting it.

@thierryvolpiatto
Copy link
Member

thierryvolpiatto commented Jun 3, 2019 via email

@achinhorn
Copy link
Author

Roger--closing & thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants