Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin minimum supported rust version in .travis.yml #60

Closed
brendanzab opened this issue Aug 21, 2020 · 3 comments
Closed

Pin minimum supported rust version in .travis.yml #60

brendanzab opened this issue Aug 21, 2020 · 3 comments

Comments

@brendanzab
Copy link

brendanzab commented Aug 21, 2020

It's hard to know what minimum supported rust version is used for this crate! This means that I'm not sure what rust version to bump to - at the moment I'm getting the following build failure when building against Rust 1.42:

error: attributes are not yet allowed on `if` expressions
##[error]   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/flexi_logger-0.15.11/src/logger.rs:163:9
    |
163 |         #[cfg(feature = "colors")]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^

It would be really useful for folks downstream if an explicit version was pinned in the .travis.yml - at the moment it's only tested against stable, beta, and nightly.

@brendanzab
Copy link
Author

Seems like the magic version is 1.43.0! It was added as a feature in rust-lang/rust#69201. So to test this as the new MSRV you just need:

rust:
  - 1.43.0
  - stable
  - beta
  - nightly

@emabee
Copy link
Owner

emabee commented Aug 22, 2020

Thanks for this proposal! I will provide a new version along that idea.

In fact, I'm trying to be compatible down to rust 1.37.0, but will need some more time to get the travis stuff fixed. Unfortunately, one of the tests doesn't compile with 1.37.0, so I will need a more sophisticated travis config.

@brendanzab
Copy link
Author

Cool! Yeah it can be nice to make sure you don't accidentally add things that introduce version regressions.

Thanks for the great work on this library anyway! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants