Standard Validatior: Types not working on `Cookies` & `Query`

[touhidurrr]

What version of Elysia is running?

1.4.4

What platform is your computer?

Microsoft Windows NT 10.0.26100.0 x64

What environment are you using

1.2.21

Are you using dynamic mode?

no

What steps can reproduce the bug?

Types not working on Cookies

import { Elysia } from 'elysia';
import { z } from 'zod';

new Elysia()
  .get('test', ({ cookie: { test } }) => test, {
    cookie: z.object({ test: z.string() }),
  })

Types not working on Query

import { Elysia } from 'elysia';
import { z } from 'zod';

new Elysia()
  .get('test', ({ cookie: { test } }) => test, {
    cookie: z.object({ test: z.string() }),
  })

What is the expected behavior?

Cookie

Equivalent TypeBox Code:

import { Elysia, t } from 'elysia';

new Elysia()
  .get('test', ({ cookie: { test } }) => test, {
    cookie: t.Object({ test: t.String() }),
  })

Result:

Query

Equivalent TypeBox Code:

import { Elysia, t } from 'elysia';

new Elysia()
  .get('test', ({ query }) => ({ query }), {
    query: t.Object({ num: t.Numeric() }),
  });

Result:

What do you see instead?

Cookie

Query

Cannot reproduce, but it does not work on one of my nested routes. I do not actually get any error, but instead all validation and coercing in query simply does not work. It just gives you plain string or undefined. Like the following:

{
  "a": "1234", // yes, even after `z.coerce.number()`.
  "b": "true", // yes, i did `z.stringbool()` here.
}

Additional information

No response

Have you try removing the node_modules and bun.lockb and try again yet?

yes

[touhidurrr]

Ok, I think the situation is more dire than I expect. Types is broken in many places randomly. Although I cannot reproduce properly, things inside a guard() call is generally affected. But not every time. Its tricky.

[SaltyAom]

Query

If I understand you correctly, you're trying to coerce the query property to a number

I'm not sure if your problem is on runtime or type problem

Since you didn't provide a query example code, I assume that it's something like this:

new Elysia()
	.get('test', ({ query: { test } }) => typeof test, {
		query: z.object({ test: z.coerce.number() })
	})

Which works on my end

At runtime, it coerces from a string to a number

In type level, it also infers type correctly

Cookie

As for the cookie, I can reproduce the bug on my end.

Locally on runtime, if the schema is a standard schema, it doesn't validate the property properly and doesn't handle coercion, which is fixed by 8099453

As for type-level it works normally

You can track the update at #1403, and test patch locally using

bun add https://pkg.pr.new/elysiajs/elysia@1403

[ekajaya740]

Tested this on Elysia 1.4.5

I also stumbled into similar issue on post request body and its only occurs when I'm not using Typebox. Below I'll give comparison of using Zod and Typebox.

---

Here's the minimal example of what I'm doing witn Zod

new Elysia()
	.post('test', ({ body }) => body, {
		body: z.object({ test: z.string() })
	})

Then I test it with Postman

Body:

{
    "test": "test"
}

Result:

{
    "value": {
        "test": "test"
    }
}

Why does it have the value wrapper?

I also try to access it with body.value and body.test but it returns undefined.

---

Everyhing different with Typebox. I'm using the same body payload so I'll only attach the results

new Elysia()
	.post('test', ({ body }) => body, {
		body: t.Object({ test: t.String() })
	})

The result:

{
    "test": "test"
}

With Typebox, I could access body.test directly and returns the correct results.

---

[SaltyAom]

Hey @ekajaya740,

I couldn't replicate this on my end with your code

Maybe there are something more to it that I was missing?

[ekajaya740]

@SaltyAom

I think it's because I'm using it alongside Astro. I'll try to replicate the issue later on a fresh project.

[touhidurrr]

@SaltyAom, both of the problems outlined here have been solved. However, I have another problem with headers. But that demands another issue. So, I will be closing this now.