-
Notifications
You must be signed in to change notification settings - Fork 472
Fix spellings on key-concept and best-practice pages #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Correct spelling errors in key-concept.md.
WalkthroughDocumentation-only changes across two markdown files involving minor grammar, pluralization, and verb tense corrections. No code logic, control flow, API modifications, or functional changes are present. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/key-concept.md`:
- Line 75: Replace the hard tab character on the Markdown line that reads
"Elysia isolates lifecycle by default unless explicitly stated. This is similar
to export in JavaScript, where you need to export the function to make it
available outside the module." with spaces (e.g., convert the tab to appropriate
spaces) so the line uses consistent space-based indentation; locate this exact
sentence in docs/key-concept.md and update the indentation to remove the hard
tab.
| <br> | ||
|
|
||
| **Elysia isolate lifecycle by default** unless explicitly stated. This is similar to **export** in JavaScript, where you need to export the function to make it available outside the module. | ||
| **Elysia isolates lifecycle by default** unless explicitly stated. This is similar to **export** in JavaScript, where you need to export the function to make it available outside the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix hard tab character.
Static analysis detected a hard tab character on this line. Markdown files should use spaces for indentation consistency.
🔧 Replace hard tab with spaces
Ensure the line uses spaces instead of a hard tab character for proper formatting.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
75-75: Hard tabs
Column: 1
(MD010, no-hard-tabs)
🤖 Prompt for AI Agents
In `@docs/key-concept.md` at line 75, Replace the hard tab character on the
Markdown line that reads "Elysia isolates lifecycle by default unless explicitly
stated. This is similar to export in JavaScript, where you need to export the
function to make it available outside the module." with spaces (e.g., convert
the tab to appropriate spaces) so the line uses consistent space-based
indentation; locate this exact sentence in docs/key-concept.md and update the
indentation to remove the hard tab.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.