-
Notifications
You must be signed in to change notification settings - Fork 32
Adds activity call stack support #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d060d3a
48abd83
b626fd7
c34a90f
6329784
758946a
658406f
22ee420
ad80b55
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using FluentMigrator; | ||
| using JetBrains.Annotations; | ||
| using static System.Int32; | ||
|
|
||
| namespace Elsa.Persistence.Dapper.Migrations.Runtime; | ||
|
|
||
| /// <inheritdoc /> | ||
| [Migration(20007, "Elsa:Runtime:V3.7")] | ||
| [PublicAPI] | ||
| [SuppressMessage("ReSharper", "InconsistentNaming")] | ||
| public class V3_7 : Migration | ||
| { | ||
| /// <inheritdoc /> | ||
| public override void Up() | ||
| { | ||
| Alter.Table("ActivityExecutionRecords").AddColumn("SerializedMetadata").AsString(MaxValue).Nullable(); | ||
| Alter.Table("ActivityExecutionRecords").AddColumn("SchedulingActivityExecutionId").AsString().Nullable(); | ||
| Alter.Table("ActivityExecutionRecords").AddColumn("SchedulingActivityId").AsString().Nullable(); | ||
| Alter.Table("ActivityExecutionRecords").AddColumn("SchedulingWorkflowInstanceId").AsString().Nullable(); | ||
| Alter.Table("ActivityExecutionRecords").AddColumn("CallStackDepth").AsInt32().Nullable(); | ||
| Alter.Table("ActivityExecutionRecords").AddColumn("AggregateFaultCount").AsInt32().NotNullable().WithDefaultValue(0); | ||
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| public override void Down() | ||
| { | ||
| Delete.Column("SerializedMetadata").FromTable("ActivityExecutionRecords"); | ||
| Delete.Column("SchedulingActivityExecutionId").FromTable("ActivityExecutionRecords"); | ||
| Delete.Column("SchedulingActivityId").FromTable("ActivityExecutionRecords"); | ||
| Delete.Column("SchedulingWorkflowInstanceId").FromTable("ActivityExecutionRecords"); | ||
| Delete.Column("CallStackDepth").FromTable("ActivityExecutionRecords"); | ||
| Delete.Column("AggregateFaultCount").FromTable("ActivityExecutionRecords"); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| using Elsa.Common.Models; | ||
| using Elsa.Persistence.Dapper.Extensions; | ||
| using Elsa.Persistence.Dapper.Models; | ||
| using Elsa.Persistence.Dapper.Modules.Runtime.Records; | ||
|
|
@@ -88,15 +89,29 @@ public async Task<long> DeleteManyAsync(ActivityExecutionRecordFilter filter, Ca | |
| return await store.DeleteAsync(q => ApplyFilter(q, filter), cancellationToken); | ||
| } | ||
|
|
||
|
|
||
| private static void ApplyFilter(ParameterizedQuery query, ActivityExecutionRecordFilter filter) | ||
| { | ||
| query | ||
| .Is(nameof(ActivityExecutionRecordRecord.Id), filter.Id) | ||
| .In(nameof(ActivityExecutionRecordRecord.Id), filter.Ids) | ||
| .Is(nameof(ActivityExecutionRecordRecord.ActivityId), filter.ActivityId) | ||
| .In(nameof(ActivityExecutionRecordRecord.ActivityId), filter.ActivityIds) | ||
| .Is(nameof(ActivityExecutionRecordRecord.ActivityNodeId), filter.ActivityNodeId) | ||
| .In(nameof(ActivityExecutionRecordRecord.ActivityNodeId), filter.ActivityNodeIds) | ||
| .Is(nameof(ActivityExecutionRecordRecord.ActivityName), filter.Name) | ||
| .In(nameof(ActivityExecutionRecordRecord.ActivityName), filter.Names) | ||
| .Is(nameof(ActivityExecutionRecordRecord.Status), filter.Status?.ToString()) | ||
| .In(nameof(ActivityExecutionRecordRecord.Status), filter.Statuses?.Select(x => x.ToString())) | ||
| .Is(nameof(ActivityExecutionRecordRecord.WorkflowInstanceId), filter.WorkflowInstanceId) | ||
| .In(nameof(ActivityExecutionRecordRecord.WorkflowInstanceId), filter.WorkflowInstanceIds); | ||
| .In(nameof(ActivityExecutionRecordRecord.WorkflowInstanceId), filter.WorkflowInstanceIds) | ||
| .Is(nameof(ActivityExecutionRecordRecord.SchedulingActivityExecutionId), filter.SchedulingActivityExecutionId) | ||
| .In(nameof(ActivityExecutionRecordRecord.SchedulingActivityExecutionId), filter.SchedulingActivityExecutionIds) | ||
| .Is(nameof(ActivityExecutionRecordRecord.SchedulingActivityId), filter.SchedulingActivityId) | ||
| .In(nameof(ActivityExecutionRecordRecord.SchedulingActivityId), filter.SchedulingActivityIds) | ||
| .Is(nameof(ActivityExecutionRecordRecord.SchedulingWorkflowInstanceId), filter.SchedulingWorkflowInstanceId) | ||
| .In(nameof(ActivityExecutionRecordRecord.SchedulingWorkflowInstanceId), filter.SchedulingWorkflowInstanceIds) | ||
| .Is(nameof(ActivityExecutionRecordRecord.CallStackDepth), filter.CallStackDepth); | ||
|
|
||
| if (filter.Completed != null) | ||
| { | ||
|
Comment on lines
115
to
117
|
||
|
|
@@ -127,6 +142,12 @@ private ActivityExecutionRecordRecord Map(ActivityExecutionRecord source) | |
| SerializedOutputs = source.Outputs?.Any() == true ? safeSerializer.Serialize(source.Outputs) : null, | ||
| SerializedException = source.Exception != null ? payloadSerializer.Serialize(source.Exception) : null, | ||
| SerializedProperties = source.Properties?.Any() == true ? safeSerializer.Serialize(source.Properties) : null, | ||
| SerializedMetadata = source.Metadata?.Any() == true ? payloadSerializer.Serialize(source.Metadata) : null, | ||
| AggregateFaultCount = source.AggregateFaultCount, | ||
| SchedulingActivityExecutionId = source.SchedulingActivityExecutionId, | ||
| SchedulingActivityId = source.SchedulingActivityId, | ||
| SchedulingWorkflowInstanceId = source.SchedulingWorkflowInstanceId, | ||
| CallStackDepth = source.CallStackDepth, | ||
| TenantId = source.TenantId | ||
| }; | ||
| } | ||
|
|
@@ -151,6 +172,12 @@ private ActivityExecutionRecord Map(ActivityExecutionRecordRecord source) | |
| Outputs = source.SerializedOutputs != null ? safeSerializer.Deserialize<IDictionary<string, object?>>(source.SerializedOutputs) : null, | ||
| Exception = source.SerializedException != null ? payloadSerializer.Deserialize<ExceptionState>(source.SerializedException) : null, | ||
| Properties = source.SerializedProperties != null ? safeSerializer.Deserialize<IDictionary<string, object>>(source.SerializedProperties) : null, | ||
| Metadata = source.SerializedMetadata != null ? payloadSerializer.Deserialize<IDictionary<string, object>>(source.SerializedMetadata) : null, | ||
| AggregateFaultCount = source.AggregateFaultCount, | ||
| SchedulingActivityExecutionId = source.SchedulingActivityExecutionId, | ||
| SchedulingActivityId = source.SchedulingActivityId, | ||
| SchedulingWorkflowInstanceId = source.SchedulingWorkflowInstanceId, | ||
| CallStackDepth = source.CallStackDepth, | ||
| TenantId = source.TenantId | ||
| }; | ||
| } | ||
|
|
@@ -170,7 +197,9 @@ private ActivityExecutionRecordSummary MapSummary(ActivityExecutionSummaryRecord | |
| HasBookmarks = source.HasBookmarks, | ||
| Status = Enum.Parse<ActivityStatus>(source.Status), | ||
| ActivityTypeVersion = source.ActivityTypeVersion, | ||
| AggregateFaultCount = source.AggregateFaultCount, | ||
| Metadata = source.SerializedMetadata != null ? payloadSerializer.Deserialize<IDictionary<string, object>>(source.SerializedMetadata) : null, | ||
| TenantId = source.TenantId | ||
| }; | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration is missing the AggregateFaultCount column. According to the changes in ActivityExecutionRecordRecord.cs, there is an AggregateFaultCount field being added to the entity (lines 88-89), and this field is being mapped in the store implementation (lines 189 and 219 in DapperActivityExecutionRecordStore.cs). However, the migration Up() method does not add this column to the database table. The Down() method should also include removal of this column for consistency.