Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling in fixes from other forks #536

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Pulling in fixes from other forks #536

merged 2 commits into from
Jan 4, 2024

Conversation

chris18890
Copy link
Collaborator

Pulling in fixes from @mjgardes & @rumplestilzken

Copy link

@joshprittse joshprittse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick inline question

@@ -350,7 +350,7 @@ function payment_data ($opts = array()) {
$clause .= "`created` ";
break;
default:
continue;
continue 2;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, it forces the continuation of the loop - https://www.php.net/manual/en/control-structures.continue.php

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, continue at this point in the code will act as a break, you need continue 2 to force the next iteration of the loop.

@chris18890 chris18890 merged commit e512ef7 into elplatt:dev Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants