Skip to content

Fix incorrect lock bucket with hash partition #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liunyl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect lock bucket with hash partition #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 17 additions & 19 deletions src/tx_operation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,32 +678,30 @@ void LockWriteRangeBucketsOp::Advance(TransactionExecution *txm)
bucket_info = txm->FastToGetBucket(bucket_id);
if (bucket_info != nullptr)
{
NodeGroupId bucket_ng = bucket_info->BucketOwner();
NodeGroupId new_bucket_ng = bucket_info->DirtyBucketOwner();

// Updates the sharding codes of this key according to bucket
// info.
const TxKey &write_tx_key = write_key_it_->first;
size_t hash = write_tx_key.Hash();
WriteSetEntry &write_entry = write_key_it_->second;
write_entry.key_shard_code_ =
(bucket_ng << 10) | (hash & 0x3FF);
// If current bucket is migrating, forward to new range owner.
if (new_bucket_ng != UINT32_MAX)
{
write_entry.forward_addr_.try_emplace(
(new_bucket_ng << 10) | (hash & 0x3FF));
txm->rw_set_.IncreaseFowardWriteCnt(1);
}
write_key_it_++;
}
else
{
break;
}
}
if (write_key_it_ != write_key_end_)
{
assert(bucket_info != nullptr);
NodeGroupId bucket_ng = bucket_info->BucketOwner();
NodeGroupId new_bucket_ng = bucket_info->DirtyBucketOwner();

// Updates the sharding codes of this key according to bucket info.
const TxKey &write_tx_key = write_key_it_->first;
size_t hash = write_tx_key.Hash();
WriteSetEntry &write_entry = write_key_it_->second;
write_entry.key_shard_code_ = (bucket_ng << 10) | (hash & 0x3FF);
// If current bucket is migrating, forward to new range owner.
if (new_bucket_ng != UINT32_MAX)
{
write_entry.forward_addr_.try_emplace((new_bucket_ng << 10) |
(hash & 0x3FF));
txm->rw_set_.IncreaseFowardWriteCnt(1);
}
}
}
else
{
Expand Down