Fix repeater and club update view permissions

elnappo · May 21, 2019 · 77bebce · 77bebce
1 parent 3c81081
commit 77bebce
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/project_novis/callsign/views.py b/project_novis/callsign/views.py
@@ -103,8 +103,10 @@ def dispatch(self, request, *args, **kwargs):
             slug = self.kwargs.get(self.slug_url_kwarg)
             try:
                 callsign_instance = Callsign.objects.get(name=slug)
-                if callsign_instance.owner != request.user:
+                if request.user.is_authenticated and callsign_instance.owner != request.user:
                     return HttpResponseForbidden()
+                elif not request.user.is_authenticated:
+                    return super().dispatch(request, *args, **kwargs)
                 self.model.objects.create(callsign=callsign_instance, created_by_id=request.user.id)
             except Callsign.DoesNotExist:
                 raise Http404(_("No callsign found matching the query") %
@@ -135,8 +137,10 @@ def dispatch(self, request, *args, **kwargs):
             slug = self.kwargs.get(self.slug_url_kwarg)
             try:
                 callsign_instance = Callsign.objects.get(name=slug)
-                if callsign_instance.owner != request.user:
+                if request.user.is_authenticated and callsign_instance.owner != request.user:
                     return HttpResponseForbidden()
+                elif not request.user.is_authenticated:
+                    return super().dispatch(request, *args, **kwargs)
                 self.model.objects.create(callsign=callsign_instance, created_by_id=request.user.id)
             except Callsign.DoesNotExist:
                 raise Http404(_("No callsign found matching the query") %