Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Light and Dark Variants #298

Closed
wants to merge 1 commit into from
Closed

Add Light and Dark Variants #298

wants to merge 1 commit into from

Conversation

sf1tzp
Copy link

@sf1tzp sf1tzp commented Nov 22, 2023

I was messing around with Telescope's colorscheme switcher and found it really nice, but with how gruvbox is distributed currently, I could not find a nice way to directly switch to the light and dark variants (#297).

I'm not sure if this is best way to approach this problem (and I am very new to the neovim ecosystem, so forgive me if I missed something obvious) - but I found that this was a pretty straightforward method of implementing the schemes. Your thoughts?

Here's how it looks on my machine
Screenshot 2023-11-21 at 11 44 38 PM

Screenshot 2023-11-21 at 11 50 36 PM

@ellisonleao
Copy link
Owner

hey @sf1tzp thanks for the PR, however, I think this is a very edge-case scenario that you can probably achieve by creating your own personal command for it. Have you tried that approach?

@sf1tzp
Copy link
Author

sf1tzp commented Nov 22, 2023

I did, but wasn't able to come up with something that worked how I wanted (eg :colorscheme gruvbox-light). I saw that other colorscheme plugins add variants like this, so I thought I would propose this here.

@sf1tzp
Copy link
Author

sf1tzp commented Nov 22, 2023

Actually, apparently I didn't try adding exactly this to my nvim/colors 😅

@sf1tzp sf1tzp closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants