fix and addition

[roymacdonald]

-Added a preprocessor define so to use the glfw clipboard only on osx as it thew an error on windows.

• Added getter and setter for text padding

[elliotwoods]

interesting. i was originally testing on windows and it was working there. i wonder if it's a problem in the glfw build on windows. i've found copy and paste isn't working for me on windows on recent oF (another addon using clipboard in the same way), didn't see the errors though (think i was going via ofxClipboard).

http://github.com/elliotwoods/ofxClipboard

maybe best would be:
a) fix ofxClipboard
b) use HAS_OFXCLIPBOARD pattern (see the recent HAS_OFXADDONNAME thread in the dev list)

happy to merge the other stuff, but a bit odd to admit clipboard for windows is broken rather than fix it.

what was the error which you got?

elliot

[elliotwoods]

also thanks for the PR! always really appreciate PR's :)

[roymacdonald]

Hi elliot,
Right, I think that the ofxClipboard approach is better.
the problem resides in this line
https://github.com/elliotwoods/ofxTextInputField/blob/master/src/ofxTextInputField.cpp#L530
as it is trying to get a cocoa window on windows.
I'll check how it works with ofxClipboard and let you know.
best

[elliotwoods]

ah ok
i just realised that this repo is mainly hosted at flightphase. you might want to put your PR over there too

[roymacdonald]

Yes, but your branch has a lot more updates than flightphase's.
I will PR over there too.
best

[elliotwoods]

thank you!
you're totally right about the osx stuff. just realised that this isn't a feature which i programmed myself.
it's probably quite simple to fix with an ifdef.

[roymacdonald]

Sure, yet I think it would be better using the HAS_OFXADDON preprocessor thing you mentioned and use ofxClipboard.