add int32s and int64s and uint32 and uint64 and float32
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luoxin
changed the title
int32s and int64sint32s and int64s and uint32 and uint64
Luoxin
changed the title
int32s and int64s and uint32 and uint64int32s and int64s and uint32 and uint64 and float32
|
Thanks for contributing, but I don't think I want to accept this change since it adds a lot of bloat to pie v1 and I would encourage anyone to upgrade to pie v2. Is there a reason that prevents you from using Go 1.18+? |
|
The business upgrade to the GO version was not as fast because some internal calls using the system layer crashed after the upgrade to 1.18. Maybe |
|
I do not want all this extra generated code to be committed for less common types. You can use pie to generate the types for your project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.