v3 #46
Merged
v3 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotchance
requested changes
Nov 30, 2024
elliotchance
requested changes
Dec 4, 2024
elliotchance
requested changes
Dec 4, 2024
- `m.Keys` returns an `iter.Seq` iterator instead of a list of keys. - Added `m.Values` which returns an `iter.Seq` iterator. - Renamed Iterator method to `AllFromFront`. - Renamed ReverseIterator to `AllFromBack`. - Added `All` method aliased to `AllFromFront`. - Updated minimum version to 1.23 - Moved methods into main file as they no longer need to be constrained by a build tag - Updated tests
elliotchance
approved these changes
Dec 4, 2024
|
Thank you @pd93 for this awesome work! It's now released as v3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
As discussed in #44, this PR proposes a couple of breaking changes (and therefore a major version bump to v3):
m.Keys()now returns aniter.Seqiterator instead of a list of keys.maps.Keysfrom the standard library.m.Values()which returns aniter.Seqiterator.maps.Valuesfrom the standard library.Iterator()method toAllFromFront().ReverseIterator()toAllFromBack().All()method aliased toAllFromFront().slices.Allandmaps.All.orderedmap.gofile as they no longer need to be constrained by a build tagI have submitted this PR in 2 commits. The first just directly copied the
v2code into the newv3directory. The second commit contains the v3 changes. This should more easily allow you to see and review the actual changes.This change is