Repository navigation
feature request: add .Clear method #55
Description
Currently, it's impossible to clear the OrderedMap keeping its capacity.
A simple implementation would be:
func (l *list[K, V]) Clear() {
l.root = Element[K, V]{} // just in case K & V are pointer types
}
func (m *OrderedMap[K, V]) Clear() {
clear(m.kv)
m.ll.Clear()
}
Activity
elliotchance commentedon Jan 14, 2025
Happy to accept a PR for this. I see clear() was introduced in Go 1.21, so for backwards compatibility it shouldn't use that function in this implementation.
novadev94 commentedon Jan 15, 2025
I see
orderedmap/v3targets Go 1.23 with generics and iterators. Maybe this.Clearmethod will only be added tov3?Doing a custom implementation for
clearwould be inefficient sincemapclearis implemented in theruntimepackage.elliotchance commentedon Jan 15, 2025
Generics were released with Go 1.18. I'm saying you can implement a Clear method, but it cannot rely on new functionality in Go 1.23, at least until 1.23 becomes old enough that its sensible to expect clients to be running that.