Skip to content

Allow for warningless OTP 21 compilation and dialyzer'ing#61

Merged
yurrriq merged 5 commits intoelli-lib:developfrom
paulo-ferraz-oliveira:feature/allow_otp_21
Jul 11, 2018
Merged

Allow for warningless OTP 21 compilation and dialyzer'ing#61
yurrriq merged 5 commits intoelli-lib:developfrom
paulo-ferraz-oliveira:feature/allow_otp_21

Conversation

@paulo-ferraz-oliveira
Copy link
Contributor

We also make for an explicit minimum OTP 18 version (in rebar.config), as per .travis.yml's example.

@coveralls
Copy link

coveralls commented Jul 10, 2018

Coverage Status

Coverage increased (+0.03%) to 75.405% when pulling 264c076 on paulo-ferraz-oliveira:feature/allow_otp_21 into 8ece9ec on elli-lib:develop.

@yurrriq
Copy link
Member

yurrriq commented Jul 11, 2018

LGTM, thanks!

@yurrriq yurrriq merged commit ac8d0dd into elli-lib:develop Jul 11, 2018
@yurrriq
Copy link
Member

yurrriq commented Jul 11, 2018

@paulo-ferraz-oliveira, does kerl support OTP 21 yet? If so, would you mind adding it to the Travis build matrix?

@fenollp
Copy link

fenollp commented Jul 11, 2018

Why yes kerl works fine on debians, alpine & osx with 21.

@paulo-ferraz-oliveira
Copy link
Contributor Author

@yurrriq: I'll add OTP 21 to the travis build matrix, since kerl supports it. Thanks for merging.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Now that I look at the PR, I don't think stacktrace_compat is required. Thing is I started the branch from master and later rebased on top of develop, but stacktrace_compat was already added. Let me check if it's possible to not have it (one less dep, :D)

@yurrriq
Copy link
Member

yurrriq commented Jul 26, 2018

Feel free to open another PR then. I'll try to be faster.

@paulo-ferraz-oliveira
Copy link
Contributor Author

@yurrriq: I don't think it's necessary, as I explained earlier. If it becomes so, in the future, I'll open a new PR, sure.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Hi. Any chance this gets tagged soon?

@yurrriq yurrriq mentioned this pull request Jan 31, 2019
@yurrriq
Copy link
Member

yurrriq commented Feb 21, 2019

Thanks for your patience! https://hex.pm/packages/elli/3.2.0

@paulo-ferraz-oliveira
Copy link
Contributor Author

Sure, @yurrriq. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants