fix(ui): generate only one thread composer in PublishWidgetList and provide it to each widget
#2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provide it to each widget
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
userquin
commented
Sep 11, 2024
| useThreadComposer(draftKey, initial).threadItems.value, | ||
| ) | ||
| const threadComposer = useThreadComposer(draftKey, initial) | ||
| const threadItems = computed(() => threadComposer.threadItems.value) |
There was a problem hiding this comment.
I still don't understand why this should be a computed, I guess it can be used with threadComposer.threadItems.value in the template
danielroe
approved these changes
Sep 11, 2024
shuuji3
pushed a commit
that referenced
this pull request
Oct 21, 2024
… provide it to each widget (#2953)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds the composer in the list sfc and pass it to each widget: the widget will use the provided or build a new one composer depending on the new optional
thread-composerprop.(fixes the vue setup warning from this #2946 (review))
@patak-dev @danielroe @shuuji3 I didn't did anything about the composer logic, maybe you can help me to test this PR properly