-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): improve gif support #2752
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is a great improvement for GIF support! 🙂
I think this is a good style that matches the official Mastodon UI and other clients.
Mastodon UI example:
Also, the small badge can avoid hiding the GIF image unnecessarily so users can view the meaning of the image even when disabling the animation.
I tested two hiding indicator settings as well as disabling the autoplay setting and all settings are working correctly.
@@ -614,6 +615,7 @@ | |||
"favourited_by": "Favorited By", | |||
"filter_hidden_phrase": "Filtered by", | |||
"filter_show_anyway": "Show anyway", | |||
"gif": "GIF", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In arabic, as far as I know, gif is جیف!
but it can be "gif" too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I didn't know that. In that case, I think it's better to keep this change for Arabic users.
gif
indicator on gif mediagif
can also enable the media preview dialogexample posts:
https://deploy-preview-2752--elk-zone.netlify.app/universeodon.com/@elkdev/112211964228804763
https://elk.zone/o3o.ca/@rikan@m.otter.homes/112061227739128715
https://elk.zone/mastodon.ktachibana.party/@furretya/112210841006362590
Before
Screen.Recording.2024-04-03.at.11.55.47.PM.mov
After:
Screen.Recording.2024-04-03.at.11.53.45.PM.mov