Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): improve gif support #2752

Merged
merged 1 commit into from
Apr 4, 2024
Merged

feat(ui): improve gif support #2752

merged 1 commit into from
Apr 4, 2024

Conversation

lazzzis
Copy link
Contributor

@lazzzis lazzzis commented Apr 4, 2024

  1. add gif indicator on gif media
  2. clicking on gif can also enable the media preview dialog

example posts:
https://deploy-preview-2752--elk-zone.netlify.app/universeodon.com/@elkdev/112211964228804763

https://elk.zone/o3o.ca/@rikan@m.otter.homes/112061227739128715
https://elk.zone/mastodon.ktachibana.party/@furretya/112210841006362590

Before

Screen.Recording.2024-04-03.at.11.55.47.PM.mov

After:

Screen.Recording.2024-04-03.at.11.53.45.PM.mov

Copy link

stackblitz bot commented Apr 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit a5503f3
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/660e52b712b3dc0008b5dc4a
😎 Deploy Preview https://deploy-preview-2752--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit a5503f3
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/660e52b72a0e9b00081acc6b

Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is a great improvement for GIF support! 🙂

I think this is a good style that matches the official Mastodon UI and other clients.

Mastodon UI example:

Screenshot from 2024-04-04 17-10-02

Also, the small badge can avoid hiding the GIF image unnecessarily so users can view the meaning of the image even when disabling the animation.

I tested two hiding indicator settings as well as disabling the autoplay setting and all settings are working correctly.

components/status/StatusAttachment.vue Show resolved Hide resolved
@@ -614,6 +615,7 @@
"favourited_by": "Favorited By",
"filter_hidden_phrase": "Filtered by",
"filter_show_anyway": "Show anyway",
"gif": "GIF",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In arabic, as far as I know, gif is جیف!

but it can be "gif" too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't know that. In that case, I think it's better to keep this change for Arabic users.

@patak-dev patak-dev added this pull request to the merge queue Apr 4, 2024
Merged via the queue into elk-zone:main with commit 8f04ea8 Apr 4, 2024
14 checks passed
maybeanerd pushed a commit to maybeanerd/crab that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants