Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing notification event type #2714

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

Sma11X
Copy link
Contributor

@Sma11X Sma11X commented Mar 29, 2024

fix #2599
This PR follows #2530. The notification event should be handled as an update event, and uri should be an attribute of entry.payload.

Steps to test :

  1. Open notification page first
  2. Receive new notifications and will see the button for new notifications

Copy link

stackblitz bot commented Mar 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit f6a8a1f
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/660628d676200c0008af2f78
😎 Deploy Preview https://deploy-preview-2714--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit f6a8a1f
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/660628d655690700081d3862

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix ❤️ ❤️ ❤️

@patak-dev patak-dev added this pull request to the merge queue Mar 29, 2024
Merged via the queue into elk-zone:main with commit 82d962a Mar 29, 2024
13 checks passed
@Sma11X Sma11X deleted the fix/add-event-type branch March 29, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications not loaded
2 participants