Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): missing and rewording es and es-419 keys #2511

Merged
merged 3 commits into from
Jan 9, 2024
Merged

feat(i18n): missing and rewording es and es-419 keys #2511

merged 3 commits into from
Jan 9, 2024

Conversation

mrcego
Copy link
Contributor

@mrcego mrcego commented Dec 15, 2023 •
edited
Loading

Changes:

  • es locale

    • account.copy_account_name
    • account.requested
    • Some reword.

  • es-419 locale

    • account.requested
    • confirm.block.confirm missing colon
    • Some reword.

cc @userquin

@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify Netlify
Copy link

netlify bot commented Dec 15, 2023 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 70dbd50
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/659d0aa741095d00080caaa5

@netlify Netlify
Copy link

netlify bot commented Dec 15, 2023 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 70dbd50
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/659d0aa70d869800085b83b2
😎 Deploy Preview https://deploy-preview-2511--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mrcego mrcego changed the title fix(i18n): missing es and es-419 keys fix(i18n): missing and rewording es and es-419 keys Dec 15, 2023
userquin
userquin approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why vscode settings changed?

@mrcego
Copy link
Contributor Author

mrcego commented Dec 15, 2023

Why vscode settings changed?

Presumable from main branch? I can revert it anyway.

@userquin
Copy link
Member

Just asking

@userquin userquin requested a review from patak-dev December 15, 2023 21:23
@patak-dev
Copy link
Member

I think no lang changes should be reverted

@patak-dev patak-dev changed the title fix(i18n): missing and rewording es and es-419 keys feat(i18n): missing and rewording es and es-419 keys Jan 9, 2024
@patak-dev patak-dev added this pull request to the merge queue Jan 9, 2024
Merged via the queue into elk-zone:main with commit 44f5ec1 Jan 9, 2024
13 checks passed
@mrcego mrcego deleted the fix-es-locale-sync branch January 9, 2024 16:27
maybeanerd pushed a commit to maybeanerd/crab that referenced this pull request Jan 28, 2024
@mrcego @patak-dev @maybeanerd
feat(i18n): missing and rewording es and es-419 keys (elk-zone#2511)
8adb935 
Co-authored-by: patak <matias.capeletto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@userquin userquin userquin approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrcego @userquin @patak-dev