Skip to content

fix: restore Node typings for build/typecheck#2

Open
lawyered0 wants to merge 2 commits intoelizaOS:mainfrom
lawyered0:codex/fix-build-types
Open

fix: restore Node typings for build/typecheck#2
lawyered0 wants to merge 2 commits intoelizaOS:mainfrom
lawyered0:codex/fix-build-types

Conversation

@lawyered0
Copy link

@lawyered0 lawyered0 commented Feb 16, 2026

Summary

Fixes TypeScript build/typecheck failures caused by missing Node ambient types.

Changes

  • add @types/node to devDependencies
  • set compilerOptions.types to ["node"] in tsconfig.json
  • keep lib as ["ES2023"] (no DOM ambient types added)

Validation

  • npm run typecheck
  • npm run build
  • npm test (434 passed, 6 skipped)

Residual risk/gap: the real EVM integration test remains environment-dependent and skips when the external plugin path is unavailable.

Summary by CodeRabbit

  • Chores
    • Updated development dependencies and TypeScript configuration for improved type support.

@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Added @types/node ^22.13.10 to devDependencies and configured TypeScript to recognize Node.js core type declarations via compilerOptions.

Changes

Cohort / File(s) Summary
Development Dependencies & TypeScript Configuration
package.json, tsconfig.json
Added @types/node package to devDependencies and enabled Node.js type declarations in TypeScript compiler options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Types now flow like gentle streams, 🌊
Node.js knowledge in TypeScript dreams,
Dependencies dance, config takes flight,
Type safety shines ever so bright! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: restore Node typings for build/typecheck' clearly and accurately summarizes the main change: restoring Node type declarations to fix TypeScript build/typecheck failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lawyered0
Copy link
Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant