-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: read modelConfig from character file #3313
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TbLtzk! Welcome to the elizaOS community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now an elizaOS contributor!
If you're interested in what https://q.org is doing with eliza: https://www.linkedin.com/posts/q-blockchain_this-morning-i-alpha-tested-q-blockchains-activity-7292567615875465221-p0fE |
Relates to
#3233
Risks
Low. IMO, this is only bringing back intended behaviour
Background
What does this PR do?
add the
modelConfig
object to the character file schema, so it is not ignored when parsing a character file.rename
max_response_length
tomaxOutputTokens
to be more consistent with the model settings type.What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Documentation changes needed?
Don't know. I did not dive that deep into the docs.
Testing
I ran a
docker-compose build
to create a new image with my changes. Than ran an agent with a characterfile including themodelConfig
object. From the API calls I could verify that my deviations from the default model settings (lower temperature, higher maxInputTokens) were applied.Discord username
@TbLtzk