Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add lint script for plugin evm and fix lint errors #1171

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

nicky-ru
Copy link
Contributor

Risks

None

Background

What does this PR do?

Improvements:

  1. Fixed Chain Name Formatting:
  • Object generation sometimes returned the chain name without quotes, causing the transfer action to fail.
  • Improved this behavior by ensuring quotes are added in the constraint:
chains.map((item) => `"${item}"`).join("|")
  1. Added Linting Script:
  • Introduced a linting script to the project and fixed the linting errors.
  1. Restored Transfer Action Logic:

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

  • Try initiate a transfer action with on the evm chain of your choice, the agent should correctly pick the chain.

The rest of the changes rely on automated tests.

Discord username

nikita_zhou

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this please add a screengrab or test of this working thanks:)

@nicky-ru
Copy link
Contributor Author

Thanks for doing this please add a screengrab or test of this working thanks:)

hi @monilpat!

Manual testing of token transfer

(ignore the "the previous tx failed", I forgot to include plugin in the character file the first time):

Screenshot 2024-12-18 at 7 40 06 PM

transaction on iotexscan: https://testnet.iotexscan.io/tx/619d23aef2d7b0c49b346d0181efabd52aef05af8315a6c33ec689349734188c

Screenshot 2024-12-18 at 7 40 32 PM Screenshot 2024-12-18 at 7 40 58 PM

And linting:

Screenshot 2024-12-18 at 7 43 29 PM

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding testing :)

@monilpat monilpat merged commit b139995 into elizaOS:develop Dec 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants