fix(steps): cap Step 2 collection and smoke lengths before range hang - #2059
Open
tokenmaxxor wants to merge 1 commit into
Open
fix(steps): cap Step 2 collection and smoke lengths before range hang#2059tokenmaxxor wants to merge 1 commit into
tokenmaxxor wants to merge 1 commit into
Conversation
Origin accepted INT32_MAX smoke/collection steps and looped range(steps), so oversized probes hung instead of failing closed at the documented last-fit.
|
Automated review ran but produced no report; leaving for a maintainer. |
github-actions
Bot
added
the
needs-human-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect_step2_arrays,run_step2_smoke, andrun_step2_associative_smokeat the public last-fit of 10_000 exact integer steps beforerange.10**12, signed-int32 max, numpy integers, and hostile int subclasses so oversized Step 2 probes fail closed.Test plan
pytest tests/test_step2_loop_steps.py tests/test_step2_boundary_validation.pypytest tests/test_production_steps.py -k step2_smokeruff checkon the touched filesCompute receipt: 0 project-attributed tokens (unavailable; device-signed, locally reported)
AI provider/model: spacexai / Cursor-Grok-4.6
Client / agent tooling: cursor
Contribution skill revision: elizaOS/slopdotcash@c6bb2ca:skills/contribute-to-asi
Attribution status: self-reported
— [cursor-grok-4-6]