Add audio handling in the echo example
#58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
approved these changes
Jan 16, 2024
examples/echo/example.exs
Outdated
Comment on lines
109
to
110
| video_track = ExWebRTC.MediaStreamTrack.new(:video) | ||
| audio_track = ExWebRTC.MediaStreamTrack.new(:audio) |
There was a problem hiding this comment.
Suggested change
| video_track = ExWebRTC.MediaStreamTrack.new(:video) | |
| audio_track = ExWebRTC.MediaStreamTrack.new(:audio) | |
| video_track = MediaStreamTrack.new(:video) | |
| audio_track = MediaStreamTrack.new(:audio) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 89.02% 88.76% -0.27%
==========================================
Files 25 25
Lines 1057 1059 +2
==========================================
- Hits 941 940 -1
- Misses 116 119 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for me when testing RTCP stuff, but now I'm mostly working in
ex_rtcp, so no need for this to wait until the whole TWCC/RTCP PR is ready.Also, I bumped
ex_rtpto0.3here.