Skip to content

Forward data received on a failed pair and re-schedule this pair #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Jul 23, 2024

Fixes #50
Fixes #48

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (c0d55fa) to head (5d2ef75).

Additional details and impacted files
@@               Coverage Diff               @@
##           srflx-cands      #53      +/-   ##
===============================================
+ Coverage        80.11%   80.56%   +0.45%     
===============================================
  Files               25       25              
  Lines             1428     1441      +13     
===============================================
+ Hits              1144     1161      +17     
+ Misses             284      280       -4     
Files Coverage Δ
lib/ex_ice/priv/conn_check_handler/controlling.ex 80.00% <100.00%> (+1.73%) ⬆️
lib/ex_ice/priv/ice_agent.ex 84.46% <91.66%> (+0.56%) ⬆️
lib/ex_ice/priv/conn_check_handler/controlled.ex 58.62% <68.00%> (+4.77%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d55fa...5d2ef75. Read the comment docs.

Base automatically changed from srflx-cands to master July 24, 2024 11:46
@mickel8 mickel8 merged commit bed3d9c into master Jul 24, 2024
2 checks passed
@mickel8 mickel8 deleted the failed-pair branch July 24, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't block data received on a failed pair Re-schedule conn-check when faild pair receives data
2 participants