Add functions to obtain ICE candidates #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
approved these changes
Mar 5, 2024
lib/ex_ice/ice_agent.ex
Outdated
| end | ||
|
|
||
| @doc """ | ||
| Gets remote candidates that have been supplied by `add_remote_candidate/2`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Gets remote candidates that have been supplied by `add_remote_candidate/2`. | |
| Gets all remote candidates. | |
| This includes candidates supplied by `add_remote_candidate/2` and candidates discovered during ICE connection establishment process (so called prflx candidates). |
lib/ex_ice/ice_agent.ex
Outdated
| @doc """ | ||
| Gets local candidates that have been already gathered. | ||
| """ | ||
| @spec get_local_candidates(pid()) :: [binary()] |
Contributor
Author
There was a problem hiding this comment.
I used the same type as in signal() with {:new_candidate, binary()}, I would rather keep it consistent and change both or none.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 80.20% 79.59% -0.61%
==========================================
Files 17 17
Lines 884 892 +8
==========================================
+ Hits 709 710 +1
- Misses 175 182 +7
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
get_local_candidates/1andget_remote_candidates/1functions.