-
-
Notifications
You must be signed in to change notification settings - Fork 40
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: swap out dets for sqlite3 (#131)
Also fixes a bug with go to definition. it turns out that multiple references were being stored that overlapped in range, so we'd get multiple references, which didn't match the pattern, so it returned nil. Now, sqlite easily deletes any references that overlap with the one we are inserting in that moment.
- Loading branch information
Showing
15 changed files
with
356 additions
and
406 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,193 @@ | ||
| defmodule NextLS.DB do | ||
| @moduledoc false | ||
| use GenServer | ||
|
|
||
| import __MODULE__.Query | ||
|
|
||
| @type query :: String.t() | ||
|
|
||
| def start_link(args) do | ||
| GenServer.start_link(__MODULE__, args, Keyword.take(args, [:name])) | ||
| end | ||
|
|
||
| @spec query(pid(), query(), list()) :: list() | ||
| def query(server, query, args \\ []), do: GenServer.call(server, {:query, query, args}) | ||
|
|
||
| @spec symbols(pid()) :: list(map()) | ||
| def symbols(server), do: GenServer.call(server, :symbols) | ||
|
|
||
| @spec insert_symbol(pid(), map()) :: :ok | ||
| def insert_symbol(server, payload), do: GenServer.cast(server, {:insert_symbol, payload}) | ||
|
|
||
| @spec insert_reference(pid(), map()) :: :ok | ||
| def insert_reference(server, payload), do: GenServer.cast(server, {:insert_reference, payload}) | ||
|
|
||
| def init(args) do | ||
| file = Keyword.fetch!(args, :file) | ||
| registry = Keyword.fetch!(args, :registry) | ||
| logger = Keyword.fetch!(args, :logger) | ||
| Registry.register(registry, :databases, %{}) | ||
| {:ok, conn} = :esqlite3.open(file) | ||
|
|
||
| NextLS.DB.Schema.init({conn, logger}) | ||
|
|
||
| {:ok, | ||
| %{ | ||
| conn: conn, | ||
| file: file, | ||
| logger: logger | ||
| }} | ||
| end | ||
|
|
||
| def handle_call({:query, query, args}, _from, %{conn: conn} = s) do | ||
| rows = __query__({conn, s.logger}, query, args) | ||
|
|
||
| {:reply, rows, s} | ||
| end | ||
|
|
||
| def handle_call(:symbols, _from, %{conn: conn} = s) do | ||
| rows = | ||
| __query__( | ||
| {conn, s.logger}, | ||
| ~Q""" | ||
| SELECT | ||
| * | ||
| FROM | ||
| symbols; | ||
| """, | ||
| [] | ||
| ) | ||
|
|
||
| symbols = | ||
| for [_pk, module, file, type, name, line, column] <- rows do | ||
| %{ | ||
| module: module, | ||
| file: file, | ||
| type: type, | ||
| name: name, | ||
| line: line, | ||
| column: column | ||
| } | ||
| end | ||
|
|
||
| {:reply, symbols, s} | ||
| end | ||
|
|
||
| def handle_cast({:insert_symbol, symbol}, %{conn: conn} = s) do | ||
| %{ | ||
| module: mod, | ||
| module_line: module_line, | ||
| struct: struct, | ||
| file: file, | ||
| defs: defs | ||
| } = symbol | ||
|
|
||
| __query__( | ||
| {conn, s.logger}, | ||
| ~Q""" | ||
| DELETE FROM symbols | ||
| WHERE module = ?; | ||
| """, | ||
| [mod] | ||
| ) | ||
|
|
||
| __query__( | ||
| {conn, s.logger}, | ||
| ~Q""" | ||
| INSERT INTO symbols (module, file, type, name, line, 'column') | ||
| VALUES (?, ?, ?, ?, ?, ?); | ||
| """, | ||
| [mod, file, "defmodule", mod, module_line, 1] | ||
| ) | ||
|
|
||
| if struct do | ||
| {_, _, meta, _} = defs[:__struct__] | ||
|
|
||
| __query__( | ||
| {conn, s.logger}, | ||
| ~Q""" | ||
| INSERT INTO symbols (module, file, type, name, line, 'column') | ||
| VALUES (?, ?, ?, ?, ?, ?); | ||
| """, | ||
| [mod, file, "defstruct", "%#{Macro.to_string(mod)}{}", meta[:line], 1] | ||
| ) | ||
| end | ||
|
|
||
| for {name, {:v1, type, _meta, clauses}} <- defs, {meta, _, _, _} <- clauses do | ||
| __query__( | ||
| {conn, s.logger}, | ||
| ~Q""" | ||
| INSERT INTO symbols (module, file, type, name, line, 'column') | ||
| VALUES (?, ?, ?, ?, ?, ?); | ||
| """, | ||
| [mod, file, type, name, meta[:line], meta[:column] || 1] | ||
| ) | ||
| end | ||
|
|
||
| {:noreply, s} | ||
| end | ||
|
|
||
| def handle_cast({:insert_reference, reference}, %{conn: conn} = s) do | ||
| %{ | ||
| meta: meta, | ||
| identifier: identifier, | ||
| file: file, | ||
| type: type, | ||
| module: module | ||
| } = reference | ||
|
|
||
| col = meta[:column] || 0 | ||
|
|
||
| {{start_line, start_column}, {end_line, end_column}} = | ||
| {{meta[:line], col}, | ||
| {meta[:line], col + String.length(identifier |> to_string() |> String.replace("Elixir.", ""))}} | ||
|
|
||
| __query__( | ||
| {conn, s.logger}, | ||
| ~Q""" | ||
| DELETE FROM 'references' AS refs | ||
| WHERE refs.file = ? | ||
| AND (? <= refs.start_line | ||
| AND refs.start_line <= ? | ||
| AND ? <= refs.start_column | ||
| AND refs.start_column <= ?) | ||
| OR (? <= refs.end_line | ||
| AND refs.end_line <= ? | ||
| AND ? <= refs.end_column | ||
| AND refs.end_column <= ?); | ||
| """, | ||
| [file, start_line, end_line, start_column, end_column, start_line, end_line, start_column, end_column] | ||
| ) | ||
|
|
||
| __query__( | ||
| {conn, s.logger}, | ||
| ~Q""" | ||
| INSERT INTO 'references' (identifier, arity, file, type, module, start_line, start_column, end_line, end_column) | ||
| VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?); | ||
| """, | ||
| [identifier, reference[:arity], file, type, module, start_line, start_column, end_line, end_column] | ||
| ) | ||
|
|
||
| {:noreply, s} | ||
| end | ||
|
|
||
| def __query__({conn, logger}, query, args) do | ||
| args = Enum.map(args, &cast/1) | ||
|
|
||
| with {:error, _e} <- :esqlite3.q(conn, query, cast(args)) do | ||
| error = :esqlite3.error_info(conn).errmsg | ||
| NextLS.Logger.error(logger, error) | ||
| {:error, error} | ||
| end | ||
| end | ||
|
|
||
| defp cast(arg) do | ||
| cond do | ||
| is_atom(arg) and String.starts_with?(to_string(arg), "Elixir.") -> | ||
| Macro.to_string(arg) | ||
|
|
||
| true -> | ||
| arg | ||
| end | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| defmodule NextLS.DB.Format do | ||
| @moduledoc false | ||
| # @behaviour Mix.Tasks.Format | ||
|
|
||
| # @impl Mix.Tasks.Format | ||
| # def features(_opts), do: [sigils: [:Q], extensions: []] | ||
|
|
||
| # @impl Mix.Tasks.Format | ||
| # def format(input, _formatter_opts, _opts \\ []) do | ||
| # path = Path.join(System.tmp_dir!(), "#{System.unique_integer()}-temp.sql") | ||
| # File.write!(path, input) | ||
| # {result, 0} = System.cmd("pg_format", [path]) | ||
|
|
||
| # File.rm!(path) | ||
|
|
||
| # String.trim(result) <> "\n" | ||
| # end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| defmodule NextLS.DB.Query do | ||
| @moduledoc false | ||
| defmacro sigil_Q({:<<>>, _, [bin]}, _mods) do | ||
| bin | ||
| end | ||
| end |
Oops, something went wrong.