Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump telemetry to established release #15

Closed
wants to merge 1 commit into from
Closed

Bump telemetry to established release #15

wants to merge 1 commit into from

Conversation

pdgonzalez872
Copy link

@pdgonzalez872 pdgonzalez872 commented Nov 7, 2022

Hi!

Thanks for the library!

Can we remove the 0.4 reference to telemetry? Seems like it is the same code and folks chose to make a 1.0 out of it. https://github.com/beam-telemetry/telemetry/blob/main/CHANGELOG.md#100

We wanted to use mentat in a project but had conflicts with cowboy_telemetry then we noticed the 1.0 release.

Hope this helps! Thanks!

@pdgonzalez872
Copy link
Author

Hi! Should we merge this?

@andyleclair
Copy link

bump! we're using Avalanche, which depends on this project, and I'd love stop having override: true to get hex to resolve

@mhanberg
Copy link
Member

Hi folks!

I'm sort of confused as to why we need to change this.

The patch as is only restrains the allowed version of telemetry.

And I checked the avalanche package and it had the same constraint as mentat, why is that causing you to need to override?

@andyleclair
Copy link

@mhanberg ah, I see what the issue is here: the latest version of Mentat in Hex is 0.7.1 but the version relaxation commit would be 0.7.2 which hasn't been released to hex. I'd think publishing that version would allow this PR to be closed (and resolve our issue!)

@mhanberg
Copy link
Member

Ahh yes.

@keathley could you publish to hex?

Going to close this then since since #14 is already an open issue.

@mhanberg mhanberg closed this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants