This repository was archived by the owner on Mar 19, 2021. It is now read-only.
fix decimal scale and precision parsing#67
Merged
mmmries merged 2 commits intoelixir-sqlite:masterfrom Jun 8, 2018
Merged
Conversation
|
Hello, @TokiTori! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
Collaborator
|
@TokiTori thanks for contributing this fix! Can you add a unit test to cover this case? You could add it right after the existing test for creating decimal columns with precision. |
Collaborator
|
I just want to make sure we keep this case covered if we refactor later to do more complete parsing. |
Collaborator
|
💛 💜 ❤️ 💙 💚 💛 💜 ❤️ 💙 💚 💛 💜 ❤️ 💙 💚 This looks great thanks! |
Collaborator
|
released this fix in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created table
price_listwith fieldprice DECIMAL(34, 10). And when I try to select data from this table, I get error. Then I create same table and field without space between precision and scale - query working.