Bump Elixir to test against to 14.2 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't need to follow Plug, as this updates less frequently, so I would stay with ~> 1.7, especially as it is a critical dependency. :) |
|
Thanks! Great to know that and it makes sense to me 👋 Is it then alright to go only with 1.13 to 1.14? |
sato11
changed the title
|
Polished after the comment. Feel free to let me know if I seem to miss the point! |
|
💚 💙 💜 💛 ❤️ |
|
Hooray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey can we perhaps now bump to
1.10 and1.14?https://hexdocs.pm/elixir/main/compatibility-and-deprecations.html
Last change was #31 where minimum required version remained 1.7. On the other hand since plug specifies 1.10 it'll feel better if we can follow it, won't it?This dropped in favor of #32 (comment).Other changes included is what I have validated in fork. Basically it's how plug configures it.