Skip to content

Add an explicit negative step to a ranger that counts down #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add an explicit negative step to a ranger that counts down #37

wants to merge 1 commit into from

Conversation

alco
Copy link

@alco alco commented May 24, 2024

Without an explicit step this emits a warning in Elixir 1.17.

@alco
Add an explicit negative step to a ranger that counts down
3d87151 
Without an explicit step this emits a warning in Elixir 1.17.
the-mikedavis
the-mikedavis approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis
Copy link
Collaborator

I pulled this in as 87f5ce4 for the sake of backwards compatibility, but thanks for the PR!

@alco
Copy link
Author

alco commented Jun 3, 2024

@the-mikedavis Super! Thanks for addressing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alco @the-mikedavis