Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action CI #44

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Add GitHub Action CI #44

merged 1 commit into from
Feb 14, 2022

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Feb 14, 2022

This resolves #43.

@josevalim josevalim merged commit 2f007fe into elixir-makeup:master Feb 14, 2022
@josevalim
Copy link
Collaborator

💚 💙 💜 💛 ❤️

@kianmeng
Copy link
Contributor Author

🎉 🎉 🎉 🎉 🎉

@kianmeng
Copy link
Contributor Author

I've noticed you've disabled the mix format job. Should we add the .formatter.exs and mix format the whole project?

@josevalim
Copy link
Collaborator

I will let @tmbb do it if he wants to. otherwise we can do it later :)

@tmbb
Copy link
Collaborator

tmbb commented Feb 27, 2022

I will let @tmbb do it if he wants to. otherwise we can do it later :)

I believe there was once a reason we weren't blindly running the formatter, right? Maybe something to do with the modules that are generated from Pygments? I can't recall what the reason was, and if no one can either, we could run the formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI
3 participants