Support ports on precompiled and use consistent option naming #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocoa-xu
reviewed
Nov 14, 2022
| * `:make_precompiler` - a two-element tuple with the precompiled type | ||
| and module to use. The precompile type is either `:nif` or `:port` | ||
| and then the precompilation module. If the type is a `:nif`, it looks | ||
| for a DDL or a shared object as precompilation target given by |
There was a problem hiding this comment.
Sorry found a typo here :)
Suggested change
| for a DDL or a shared object as precompilation target given by | |
| for a DLL or a shared object as precompilation target given by |
|
@josevalim Thanks! This update makes me really happy. On a quick skim of the PR, it looks pretty good. I'm getting pulled into meetings now, but I promise to try with Nerves libraries later today. No need to hold up on my account. I suspect that if I find anything, it won't specifically be with this PR. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @cocoa-xu @fhunleth