Skip to content

Fix .iex.exs error behaviour #8618 #8619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 15, 2019
Merged

Fix .iex.exs error behaviour #8618 #8619

merged 5 commits into from
Jan 15, 2019

Conversation

@f1sty
Copy link
Contributor

@f1sty f1sty commented Jan 13, 2019

Loading .iex.exs with compile or runtime errors currently halts the system.
This fix intended to print error message, but still run iex with default state.

@josevalim
Copy link
Member

josevalim commented Jan 13, 2019 via email

@f1sty
Copy link
Contributor Author

f1sty commented Jan 13, 2019

Added test for malformed .iex, check if it sufficient, please.

fertapric
fertapric reviewed Jan 14, 2019
View reviewed changes
@josevalim
Copy link
Member

Thanks @f1sty! Your PR was written on top of a very old master. Can you please rebase master and rebase your PR? After that, make sure to run make compile && mix format && make test. Thank you.

@f1sty
Copy link
Contributor Author

f1sty commented Jan 14, 2019

Can you please rebase master and rebase your PR? After that, make sure to run make compile && mix format && make test.

Done;)

@josevalim
Copy link
Member

josevalim commented Jan 14, 2019 •
edited
Loading

@f1sty unfortunately your PR has unrelated changes now, probably because i told you to run mix format but you probably should have run bin/elixir bin/mix format (sorry!). Can you please exclude teh unrelated changes from your PR and push?

This was referenced Jan 14, 2019
Closed
Closed
@f1sty
Copy link
Contributor Author

f1sty commented Jan 15, 2019

Sorry, removed unrelated changes.

fertapric
fertapric reviewed Jan 15, 2019
View reviewed changes
lib/iex/test/iex/interaction_test.exs Outdated
File.write!("dot-iex", "malformed")

assert capture_iex("malformed", [], dot_iex_path: "dot-iex") =~
"** (CompileError) iex:1: undefined function malformed/0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be dot-iex :)

Suggested change
"** (CompileError) iex:1: undefined function malformed/0"
"** (CompileError) dot-iex:1: undefined function malformed/0"

Besides, I would use a different input for the capture_iex function so it's clear the error comes from the "dot iex" file.

@josevalim josevalim merged commit b711d08 into elixir-lang:master Jan 15, 2019
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@f1sty
Copy link
Contributor Author

f1sty commented Jan 15, 2019

🎂 Thanks!

@f1sty f1sty deleted the issue8618 branch January 15, 2019 14:15
@f1sty f1sty restored the issue8618 branch January 15, 2019 14:16
@fhunleth fhunleth mentioned this pull request Mar 25, 2020
Closed
fhunleth added a commit to nerves-project/nerves_bootstrap that referenced this pull request Mar 25, 2020
@fhunleth
Remove note about crashing Erlang
1f68c58 
This was fixed in Elixir 1.9.0. See
elixir-lang/elixir#8619 for PR.
@fhunleth fhunleth mentioned this pull request Mar 25, 2020
Merged
mobileoverlord pushed a commit to nerves-project/nerves_bootstrap that referenced this pull request Mar 25, 2020
@fhunleth @mobileoverlord
Remove note about crashing Erlang
7ec41bb 
This was fixed in Elixir 1.9.0. See
elixir-lang/elixir#8619 for PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fertapric fertapric fertapric left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@f1sty @josevalim @fertapric