Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for some operations with decimals #988

Merged
merged 14 commits into from
Oct 16, 2024
Merged

Add support for some operations with decimals #988

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6e584bc
Add support for decimals in `Series.from_list/2`
philss Sep 18, 2024
cbc7e59
Add support for decimals in some of the series operations
philss Sep 19, 2024
3bdf370
Document and allow more operations on decimals
philss Sep 20, 2024
1cd450c
Add type specs for the new `:decimal` dtype
philss Oct 1, 2024
32c3478
Add error about fill_missing/2 with decimals
philss Oct 7, 2024
83afad1
Add some tests covering decimals
philss Oct 8, 2024
ed66f21
Refactor dtype detection algo for decimals
philss Oct 9, 2024
483aa9e
Fix "number" guards to accept decimals and add docs
philss Oct 9, 2024
eddfe4f
Add more complex example with decimal and mutate
philss Oct 9, 2024
7ac53e0
Use a standard name from the `:decimal` dtypes
philss Oct 9, 2024
1ff3cf8
Apply suggestions from code review
philss Oct 11, 2024
02f2ddc
Use default precision as 38 and remove aliases
philss Oct 11, 2024
bff71d4
Apply suggestions from code review
philss Oct 13, 2024
2b535a0
Use max precision instead of nil for decimal dtype
philss Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use a standard name from the :decimal dtypes
  • Loading branch information
@philss
philss committed Oct 9, 2024
commit 7ac53e018583a7c8bd5e4d37b012df6afa0cc0ba
14 changes: 9 additions & 5 deletions lib/explorer/series.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2601,7 +2601,7 @@ defmodule Explorer.Series do

* floats: #{Shared.inspect_dtypes(@float_dtypes, backsticks: true)}
* integers: #{Shared.inspect_dtypes(@integer_types, backsticks: true)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, there is a typo here, it should be backticks but we fix it later. :D

* decimals. The result will be a float.
* `:decimal`. The result will be a float.
philss marked this conversation as resolved.
Show resolved Hide resolved

## Examples

Expand Down Expand Up @@ -2675,7 +2675,7 @@ defmodule Explorer.Series do

* floats: #{Shared.inspect_dtypes(@float_dtypes, backsticks: true)}
* integers: #{Shared.inspect_dtypes(@integer_types, backsticks: true)}
* decimals. The result will be a float.
* `:decimal`. The result will be a float.

## Examples

Expand Down Expand Up @@ -2745,7 +2745,7 @@ defmodule Explorer.Series do

* floats: #{Shared.inspect_dtypes(@float_dtypes, backsticks: true)}
* integers: #{Shared.inspect_dtypes(@integer_types, backsticks: true)}
* decimals. The result will be a float.
* `:decimal`. The result will be a float.

## Examples

Expand Down Expand Up @@ -2917,7 +2917,7 @@ defmodule Explorer.Series do

* floats: #{Shared.inspect_dtypes(@float_dtypes, backsticks: true)}
* integers: #{Shared.inspect_dtypes(@integer_types, backsticks: true)}
* decimals. The result will be a float.
* `:decimal`. The result will be a float.

## Examples

Expand Down Expand Up @@ -2949,7 +2949,7 @@ defmodule Explorer.Series do

* floats: #{Shared.inspect_dtypes(@float_dtypes, backsticks: true)}
* integers: #{Shared.inspect_dtypes(@integer_types, backsticks: true)}
* decimals. The result will be a float.
* `:decimal`. The result will be a float.

## Examples

Expand Down Expand Up @@ -4243,6 +4243,7 @@ defmodule Explorer.Series do
* `:time`
* `:datetime`
* `:duration`
* `:decimal`

## Examples

Expand Down Expand Up @@ -4282,6 +4283,7 @@ defmodule Explorer.Series do
* `:time`
* `:datetime`
* `:duration`
* `:decimal`

## Examples

Expand Down Expand Up @@ -4321,6 +4323,7 @@ defmodule Explorer.Series do
* `:time`
* `:datetime`
* `:duration`
* `:decimal`

## Examples

Expand Down Expand Up @@ -4360,6 +4363,7 @@ defmodule Explorer.Series do
* `:time`
* `:datetime`
* `:duration`
* `:decimal`

## Examples

Expand Down
Loading