Add count_matches/2, re_count_matches/2, re_scan/2 and re_named_captures/2 to Series
#895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions are useful to extract matches from text using regexes. For an implementation detail we cannot support the `re_named_captures/2` inside the context of queries: it's not possible to calculate the output dtype.
josevalim
approved these changes
Apr 16, 2024
josevalim
reviewed
Apr 16, 2024
| You must write: | ||
|
|
||
| Explorer.DataFrame.put(df, :new_column, Explorer.Series.re_named_captures(column, ~S/(a|b)/)) | ||
| """ |
There was a problem hiding this comment.
We could probably make this work by storing the original backend as a field of the the LazySeries and then asking it to return the names. But we can do this in another PR if desired, no worries for now IMO.
There was a problem hiding this comment.
I don't know yet how to capture that information in the context of the lazy frame, but I will research a bit. For now I'm going to merge this. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a step to support more operations with regexes.
The only detail here is that we cannot support
re_named_captures/2inside the context of a query, because we cannot extract the groups for the regex string, since that regex is following the rules of the backend (at the point ofLazySeries, we don't have access to the backend).Closes #353