Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement - nil datatype - polar null type column #805

Merged
merged 4 commits into from
Jan 9, 2024
Merged

implement - nil datatype - polar null type column #805

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76a04bf
initial version of nil series
lkarthee Jan 9, 2024
2cade24
review changes
lkarthee Jan 9, 2024
bcdf47b
add tests
lkarthee Jan 9, 2024
6e551d0
Update test/explorer/series_test.exs
josevalim Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/explorer/series_test.exs
  • Loading branch information
@josevalim
josevalim authored Jan 9, 2024
commit 6e551d0a16b6009cd0373c5304b54f746931f00c
11 changes: 0 additions & 11 deletions test/explorer/series_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3442,17 +3442,6 @@ defmodule Explorer.SeriesTest do
assert Series.dtype(s1) == :null
end

test "error when to_iovec with :null dtype" do
assert_raise ArgumentError,
~r"cannot convert series of dtype :null into iovec",
fn ->
[1, 2, nil]
|> Series.from_list()
|> Series.cast(:null)
|> Series.to_iovec()
end
end

test "integer series to string" do
s = Series.from_list([1, 2, 3])
s1 = Series.cast(s, :string)
Expand Down
Loading