Add LazyFrame version of to_parquet/3
#496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the representation of parquet compression much simplier, with an enum. We validate that at the Elixir side.
This is going to save a lazy frame to a parquet file using a stream. This should keep the memory usage low for bigger files.
josevalim
reviewed
Feb 6, 2023
|
|
||
| @impl true | ||
| def to_parquet(_df, _filename, _compression) do | ||
| raise "to_parquet/3 with groups is not supported yet for lazy frames" |
There was a problem hiding this comment.
Do groups matter on these operations? I think the group is just ignored, no?
There was a problem hiding this comment.
Yeah, it's going to be ignored. But I chose to raise to avoid confusion when the person is trying to write a grouped DF to a file.
josevalim
approved these changes
Feb 6, 2023
This was referenced Feb 6, 2023
liamdiprose
pushed a commit
to liamdiprose/explorer
that referenced
this pull request
Feb 16, 2023
Ignore MIX_ENV for build profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to save a lazy frame to a parquet file using a stream.
This should keep the memory usage low for bigger files.