Add Series.categories/1 #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is useful to retrieve only the categories from a categorical series. The resultant series is of ":string" dtype.
josevalim
reviewed
Jan 9, 2023
| @doc """ | ||
| Return a series with the category names of a categorical series. | ||
|
|
||
| Each category has the index equal to its position. |
There was a problem hiding this comment.
Should we add a note that no order is guaranteed for the categories?
There was a problem hiding this comment.
I'm not sure. For what I could understand, the ordering is defined by the order the elements appear in the series. But this is not clear.
Internally there is a flag to the the ordering to lexical: https://pola-rs.github.io/polars/polars_core/datatypes/categorical/struct.CategoricalChunked.html#method.set_lexical_sorted
There was a problem hiding this comment.
I think it is defined like that but mostly as an implementation accident and not a guarantee? Providing fewer guarantees doesn’t hurt anyway :)
There was a problem hiding this comment.
Makes sense. Note added 👍
josevalim
reviewed
Jan 9, 2023
josevalim
approved these changes
Jan 9, 2023
liamdiprose
pushed a commit
to liamdiprose/explorer
that referenced
this pull request
Feb 16, 2023
…nt-release Prepare rustler_bigint release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is useful to retrieve only the categories from a categorical series.
The resultant series is of ":string" dtype.