-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heex support #557
Heex support #557
Conversation
skip interpolation strings
Hi @jbodah, as u may notice I'm not a I'll be glad to help improving |
Thanks for taking this on @ponyesteves—this has been driving me a little nuts! The only comment I have on your PR is that you forgot to uncomment the guard clause (I'm not the owner of the repo, of course, I just follow it). Also, just looking at your screenshot, did you know you can pass a list to the <div class={["list-item_group", "text-secondary", maybe_hidden_balance_class(balance)]}>
It's also nice because if |
Hey @sodapopcan thanks for your suggestion, I've address it. It seems I missed on removing my trial and error comment. I was trying to find out how all this vim scripting works, so great catch. TIL 👇 <div class={["list-item_group", "text-secondary", maybe_hidden_balance_class(balance)]}> Great advice on using Lists to avoid String interpolation. I'm migrating some of my projects to |
Any news ? If you want to continue using this repo I add the following script to my
|
Hi all - thanks for the patches. I can merge however I do not intend to much more support for vim-elixir going forward as I have been far removed from Elixir for several years now. If anyone would like to take the maintenance reins then please let me know and I can coordinate with the Elixir team to have you added as a maintainer |
Was not able to get new unit tests for heex working on this, however tested manually and confirmed no regressions in existing suite |
@jbodah Thanks for merging this. |
Add support for heex (single curly braces)
<div id={@id}>
, skip interpolation strings inside Heex expressions.Address 👇 #555
Before:
After: