New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode all possible DB options #546

Merged

jbodah merged 1 commit into elixir-editors:master from hauleth:fix/encode-all-db-options

May 16, 2021

Contributor

hauleth commented May 14, 2021

Previous implementation was buggy in several ways:

It required :username, :password, :hostname, and :database fields while only :database is required by Ecto
It ignored c:init/2 in the repo definition
It ignored additional options passed to the repository
Did not allowed for :socket_dir configuration

This fixes all these problems at once.


          fix(dadbod): encode all possible DB options

fd77a6c

jbodah merged commit 6dc61ad into elixir-editors:master

Collaborator

jbodah commented May 16, 2021

LGTM

hauleth deleted the fix/encode-all-db-options branch

November 16, 2021 08:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet